Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7104: Duplicated tag added to page #7109

Merged

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Nov 14, 2024

Description

PR due to a revert

Fixes #7104
As of right now we are having 2 local css file tag in the html, with this PR we are fixing the issue by avoiding the preload tag to be added while combining google font. This way we endup with only 1 tag added to the html.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Please refer to issue.

Technical description

Documentation

We are adding a filter to avoid the preload tag to be added to the new feature. However, if needed we can still get the preload in the future.

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Copy link

codacy-production bot commented Nov 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 061f8b61 72.73% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (061f8b6) Report Missing Report Missing Report Missing
Head commit (7f19684) 38230 16761 43.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7109) 11 8 72.73%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Miraeld Miraeld merged commit 6fcdd7a into feature/host-google-fonts Nov 14, 2024
11 of 12 checks passed
@Miraeld Miraeld deleted the fix/7104-duplicated-tag-added-to-page-2 branch November 14, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants