Fixes #6892 Attempt to read property "id" on bool [...] AbstractQueries.php

[Khadreal]

Description

Fixed error with attempt to read property on false

Fixes #6892

Type of change

• Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check https://wp-media.slack.com/archives/C43T1AYMQ/p1728661812952229 for more detailed

Technical description

Add a check before for the item object and if the id is set before attempting to delete

Documentation

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for d4a50ba1	✅ 100.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (d4a50ba)	Report Missing	Report Missing	Report Missing
Head commit (9b7d0c8)	37748	16596	43.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7032)	2	2	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Mai-Saad]

Since there are no clear reproducible steps, here is a plan for smoke on clear performance hints https://wpmediaqa.testrail.io/index.php?/runs/view/913&group_by=cases:section_id&group_order=asc

[Mai-Saad]

Smoke test for delete URLs from DB is good.
testrail-report-648.pdf