Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6882 Update Action Scheduler to v3.8.1 #6906

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

remyperona
Copy link
Contributor

Description

Fixes #6882

Documentation

User documentation

Update Action Scheduler to v3.8.1

Technical documentation

Updated the Cleaner class to match with the changes in the parent class

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

  • Action Scheduler 3.8.1

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Aug 23, 2024
@remyperona remyperona added this to the 3.17 milestone Aug 23, 2024
@remyperona remyperona requested a review from a team August 23, 2024 17:10
@remyperona remyperona self-assigned this Aug 23, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6c039041 20.18% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6c03904) Report Missing Report Missing Report Missing
Head commit (9538ed3) 37566 9465 25.20%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6906) 436 88 20.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Aug 28, 2024

Copy link
Contributor

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Tabrisrp for this PR.
Thank you @jeawhanlee for helping with the testing.
Here are the test results:
testrail-report-636.pdf

@remyperona remyperona added this pull request to the merge queue Sep 3, 2024
Merged via the queue into develop with commit a386683 Sep 3, 2024
11 of 12 checks passed
@remyperona remyperona deleted the enhancement/6882-as-update branch September 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Action scheduler to 3.8.1 to prevent warning in specific scenario
4 participants