Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a postinstall script to automaticlly build wp-rocket-scripts dist… #6871

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

MathieuLamiot
Copy link
Contributor

… if needed

gitignore package-lock.json

Description

Follow up of #12 in rocket-scripts so that the rocket-scripts is automatically built after npm install, if needed.
This PR needs wp-media/rocket-scripts#19 as well to work properly.

Documentation

User documentation

When running npm install, rocket-scripts will be built automatically if we are targetting a dev branch and the dist/ files are not available.

Technical documentation

NA

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).

@MathieuLamiot MathieuLamiot self-assigned this Aug 16, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2cdeb581 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2cdeb58) Report Missing Report Missing Report Missing
Head commit (2aa2bf0) 37567 14273 37.99%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6871) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@MathieuLamiot MathieuLamiot added this pull request to the merge queue Aug 20, 2024
Merged via the queue into develop with commit e40643e Aug 20, 2024
12 checks passed
@MathieuLamiot MathieuLamiot deleted the enhancement/wp-rocket-scripts-auto-build branch August 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant