Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor service providers instantiation & subscribers declaration in the main plugin class #7223

Open
remyperona opened this issue Jan 10, 2025 · 0 comments
Labels
dev initiative effort: [S] 1-2 days of estimated development time

Comments

@remyperona
Copy link
Contributor

In the main plugin class:

  • We currently instantiate & add to the container each service provider one by one
  • We use array of subscribers aliases to add them to the event manager

While it works, it represents a lot of line of codes for something that could be done by using a couple of loops and config files.

This is something we already do in Imagify & RocketCDN, so we can replicate a similar strategy here.

Scope a solution ✅

For the service providers instantiation:

For the subscribers part:

Estimate the effort ✅

Effort [S]

@remyperona remyperona added dev initiative effort: [S] 1-2 days of estimated development time labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev initiative effort: [S] 1-2 days of estimated development time
Projects
None yet
Development

No branches or pull requests

1 participant