handle the titles in the method directly

wp-media · Nov 14, 2024 · e07d104 · e07d104
1 parent c7c0839
commit e07d104
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/inc/Engine/Optimization/DynamicLists/DynamicLists.php b/inc/Engine/Optimization/DynamicLists/DynamicLists.php
@@ -105,12 +105,17 @@ public function update_lists_from_remote() {
 		$response     = [];
 		$success      = false;
 		$should_purge = false;
+		$titles = [
+			'defaultlists'         => __( 'Default Lists', 'rocket' ),
+			'delayjslists'         => __( 'Delay JavaScript Execution Exclusion Lists', 'rocket' ),
+			'incompatible_plugins' => __( 'Incompatible plugins Lists', 'rocket' ),
+ 		];
 
-		foreach ( $this->providers as $provider ) {
+		foreach ( $this->providers as $provider_id => $provider ) {
 			$result = $provider->api_client->get_exclusions_list( $provider->data_manager->get_lists_hash() );
 
 			if ( empty( $result['code'] ) || empty( $result['body'] ) ) {
-				$response[ $provider->title ] = [
+				$response[ $titles[ $provider_id ] ] = [
 					'success' => false,
 					'data'    => '',
 					'message' => __( 'Could not get updated lists from server.', 'rocket' ),
@@ -119,7 +124,7 @@ public function update_lists_from_remote() {
 			}
 
 			if ( 206 === $result['code'] ) {
-				$response[ $provider->title ] = [
+				$response[ $titles[ $provider_id ] ] = [
 					'success' => true,
 					'data'    => '',
 					'message' => __( 'Lists are up to date.', 'rocket' ),
@@ -128,7 +133,7 @@ public function update_lists_from_remote() {
 			}
 
 			if ( ! $provider->data_manager->save_dynamic_lists( $result['body'] ) ) {
-				$response[ $provider->title ] = [
+				$response[ $titles[ $provider_id ] ] = [
 					'success' => false,
 					'data'    => '',
 					'message' => __( 'Could not update lists.', 'rocket' ),
@@ -137,7 +142,7 @@ public function update_lists_from_remote() {
 			}
 
 			$success                      = true;
-			$response[ $provider->title ] = [
+			$response[ $titles[ $provider_id ] ] = [
 				'success' => true,
 				'data'    => '',
 				'message' => __( 'Lists are successfully updated.', 'rocket' ),

diff --git a/inc/Engine/Optimization/DynamicLists/ServiceProvider.php b/inc/Engine/Optimization/DynamicLists/ServiceProvider.php
@@ -69,19 +69,17 @@ public function register(): void {
 				(object) [
 					'api_client'   => $this->getContainer()->get( 'dynamic_lists_defaultlists_api_client' ),
 					'data_manager' => $this->getContainer()->get( 'dynamic_lists_defaultlists_data_manager' ),
-					'title'        => 'default-lists',
 				],
 			'delayjslists'         =>
 				(object) [
 					'api_client'   => $this->getContainer()->get( 'dynamic_lists_delayjslists_api_client' ),
 					'data_manager' => $this->getContainer()->get( 'dynamic_lists_delayjslists_data_manager' ),
-					'title'        => 'delay-js-lists',
 				],
 			'incompatible_plugins' =>
 				(object) [
 					'api_client'   => $this->getContainer()->get( 'dynamic_lists_incompatible_plugins_lists_api_client' ),
 					'data_manager' => $this->getContainer()->get( 'dynamic_lists_incompatible_plugins_lists_data_manager' ),
-					'title'        => 'incompatible-plugins-lists',
+					'clear_cache'  => false,
 				],
 		];