Merge pull request #13 from wp-media/fix/save-data-conditionally

Only save data if one beacon feature ran
wp-media · Aug 14, 2024 · 821dd18 · 821dd18
2 parents 74760fb + 17e500a
commit 821dd18
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/dist/wpr-beacon.js b/dist/wpr-beacon.js
@@ -223,14 +223,21 @@
         this._handleInfiniteLoop();
       }, 1e4);
       const isGeneratedBefore = await this._getGeneratedBefore();
+      let shouldSaveResultsIntoDB = false;
       const shouldGenerateLcp = this.config.status.atf && isGeneratedBefore === false;
       if (shouldGenerateLcp) {
         this.lcpBeacon = new BeaconLcp_default(this.config, this.logger);
         await this.lcpBeacon.run();
+        shouldSaveResultsIntoDB = true;
       } else {
         this.logger.logMessage("Not running BeaconLcp because data is already available");
       }
-      this._saveFinalResultIntoDB();
+      if (shouldSaveResultsIntoDB) {
+        this._saveFinalResultIntoDB();
+      } else {
+        this.logger.logMessage("Not saving results into DB as no beacon features ran.");
+        this._finalize();
+      }
     }
     async _isValidPreconditions() {
       const threshold = {

diff --git a/dist/wpr-beacon.min.js b/dist/wpr-beacon.min.js