Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Page #5

Open
2 of 7 tasks
lizkaraffa opened this issue Jun 29, 2017 · 6 comments
Open
2 of 7 tasks

Account Page #5

lizkaraffa opened this issue Jun 29, 2017 · 6 comments

Comments

@lizkaraffa
Copy link
Collaborator

lizkaraffa commented Jun 29, 2017

Loves

  • elegant
  • clear delineation from different settings
  • parallax sidebar that scrolls with you
  • Love the "Return this" button

Opportunities

  • I find myself wanting the sidebar to always be visible so I can go to other settings without scrolling back up. On the order history if there is a lot of history I have to scroll back up to visit the other settings
  • I think mobile responsiveness got missed on this page https://cloudup.com/czu8-IPl1W9
  • On Order History: I don't love the date format of May 23rd 2017, and that might be tricky functionality wise (or it could be really easy not sure) I think May 23, 2017 is a little better personally
  • On Order History: It might be cool if the orders were collapseable/expandable to help minimize scrolling. On collapse show the date, order number, and total. Then expanded the beauties you've got. Or you could have newest order always expanded and then subsequent collapsed.
  • On Order History: It might be nice if the product titles are linkable back to product page.
  • On Profile settings (and elsewhere), I've noticed throughout the theme you have First and Last name together as one text field, @JustinSainton will need to weigh in but i think WP expects them to be separate.
  • On Billing Info, another @JustinSainton weigh in but I don't think sites are built to ever save credit card data on them. The design is perfect if that is something to save.

Clarification

  • On Order History: what's the expected behavior of "Return this"? As cool as this is, I don't think it comes with WPEC out of the box, but still a cool design for an add-on. But that's an @JustinSainton weigh in.
@JustinSainton
Copy link
Member

On Order History: I don't love the date format of May 23rd 2017, and that might be tricky functionality wise (or it could be really easy not sure) I think May 23, 2017 is a little better personally

It will probably follow whatever format the user sets in their WordPress settings.

On Profile settings (and elsewhere), I've noticed throughout the theme you have First and Last name together as one text field, @JustninSainton will need to weigh in but i think WP expects them to be separate.

Yep, that's generally the case - though it wouldn't be terribly difficult to have the "Full Name" fields here basically map to the display_name property for users, do some logic to parse out the first name from the last name wherever we may need those.

On Billing Info, another @JustinSainton weigh in but I don't think sites are built to ever save credit card data on them. The design is perfect if that is something to save.

Not totally sure what this is referring to (Not seeing this page on the demo site). But if there's an account area that saves card profiles - while we don't do that in core, having styling support for it for gateways that can do it (like Stripe/Authorize.net) is great.

@lizkaraffa
Copy link
Collaborator Author

@JustinSainton here is an image of the billing settings with the credit card box https://cloudup.com/cfGN7OX26jr

@JustinSainton
Copy link
Member

Got it! Yeah, most API tokenizations don't actually provide a way for you to edit the card details on site, rather, they list them out.

You can see how Woocommerce handles that here: https://woocommerce.wordpress.com/2016/04/04/payment-token-api-in-2-6/ and here: https://docs.woocommerce.com/document/advanced-payment-gateway-features/#add-method

@lizkaraffa
Copy link
Collaborator Author

lizkaraffa commented Jun 29, 2017

@JustinSainton can you also weigh in on this clarification.

On Order History: what's the expected behavior of "Return this"? As cool as this is, I don't think it comes with WPEC out of the box, but still a cool design for an add-on. But that's an @JustinSainton weigh in.

@JustinSainton
Copy link
Member

sure thing! yeah, that's a very cool idea, but the concept of "returns" for physical items would be very tied to warehousing, refunds, etc. that we don't have a lot of core support for. Probably fine to skip that.

@JustinSainton
Copy link
Member

That said, we do have core support for Shipwire, which has an API for returns - so it's not something that we could never conceivably support. Keeping it available would be cool, when we build the theme, we can wrap it in something like if ( theme_supports( 'returns' )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants