Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting expectation of failing tests to true to force deployment #288

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

hechth
Copy link
Contributor

@hechth hechth commented Jan 22, 2025

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR does something else (explain below)

This PR checks if the tests can be made to pass to actually deploy all recently changed tools to finish the pulsarification update

@lecorguille
Copy link
Member

Hum... is the idea is to bypass the tests?

@hechth
Copy link
Contributor Author

hechth commented Jan 22, 2025

Hum... is the idea is to bypass the tests?

yes exactly - those 2 are failing and need to be fixed, but in case of isoplot the package is broken and in case of NMR annotation the results are different, which should probably be investigated.

@hechth
Copy link
Contributor Author

hechth commented Jan 22, 2025

I would like to get the other tools to get deployed onto the toolshed since they are fine

@lecorguille
Copy link
Member

Can we have an issue to track the tools that need to be repaired?

Is there any mecanism to skip them to be pushed in a new version on the TS? I not confortable to update tools that doesn't pass the tests. Maybe by renaming the .shed.yml?

@hechth
Copy link
Contributor Author

hechth commented Jan 22, 2025

Well the current tools are also broken so there isn't really a big difference to the status quo unfortunately.

@melpetera
Copy link
Member

I created an issue #290 to keep track of this. Is it okay like this?

@lecorguille lecorguille merged commit b5f7f56 into master Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants