Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tool: influx-si--data-manager v1.0.0 #257

Conversation

llegregam
Copy link
Contributor

@llegregam llegregam commented Jan 17, 2024

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

tools/influx_data_manager/influx_data_manager.xml Outdated Show resolved Hide resolved
tools/influx_data_manager/influx_data_manager.xml Outdated Show resolved Hide resolved
tools/influx_data_manager/influx_data_manager.xml Outdated Show resolved Hide resolved
tools/influx_data_manager/influx_data_manager.xml Outdated Show resolved Hide resolved
tools/influx_data_manager/influx_data_manager.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • there is a strange Documents folder in this PR
    I'm a bit confused about the name "data manager". Data managers in Galaxy are very specific admin-only tools. This is not what you want to develop here, isn't it?

Maybe we can rename the tool and avoid the data-manager name?

@llegregam
Copy link
Contributor Author

@bgruening

  • there is a strange Documents folder in this PR

Apparently this was created by planemo during testing. It seems to have been a shortcut towards the galaxy folder I had configured for the tests. It has been removed

  • I'm a bit confused about the name "data manager". Data managers in Galaxy are very specific admin-only tools. This is not what you want to develop here, isn't it?

Yes so long story short for a workflow I am building I used the term data manager for two specific tools that handle data interoperability within the workflow. This was before I noticed that the term would conflict with the Galaxy term. The problem is I already have one that is online under the name physiofit-data-manager, and I already have published the tool on pypi as well. So renaming would be a real hastle. I'm sorry for the confusion raised by this mistake...

*Maybe we can rename the tool and avoid the data-manager name?

See the answer above!

@llegregam llegregam requested a review from bgruening January 23, 2024 07:22
@llegregam
Copy link
Contributor Author

llegregam commented Jan 29, 2024

@bgruening @lecorguille @yguitton
Could I please get a review or answers to my questions? :)

@bgruening
Copy link
Contributor

bgruening commented Feb 3, 2024

This was before I noticed that the term would conflict with the Galaxy term. The problem is I already have one that is online under the name physiofit-data-manager, and I already have published the tool on pypi as well. So renaming would be a real hastle. I'm sorry for the confusion raised by this mistake...

You call, but I guess its better to change now, instead of adding more tools with this term. To be clear I'm only talking about the user facing name. The tool name etc. If the package/script is called like that is not important imho.

@llegregam llegregam requested a review from bgruening February 7, 2024 10:22
@lecorguille lecorguille merged commit 6e361ee into workflow4metabolomics:master Feb 9, 2024
9 checks passed
@llegregam llegregam deleted the add_influx_data_manager_1_0_0 branch March 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants