-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] 같은 스터디 진행 이후 다른 멤버 스터디 기록이 조회되지 않는 오류 수정 #758
[BE] 같은 스터디 진행 이후 다른 멤버 스터디 기록이 조회되지 않는 오류 수정 #758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요!
하루스터디 PR 검토하는거 되게 오랜만이네요 ㅋㅋ
저도 덕분에 복기하면서 리뷰할 수 있었습니다!
고생하셨고, 혹시 공유해야 할 사안이나 나눠서 처리해야 하는 작업이 있다면 언제든 말씀해주세요~
} | ||
} | ||
|
||
private boolean isMemberIncludedInParticipants(Member member, List<Participant> participants) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
멤버가 참여자가 아니라면 true를 반환하는 메소드네요!
메소드명이 isMemberNotIncludedInParticipants
여야 할 것 같은데, 아마 오타가 난 것 같습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이래서 코드리뷰 하는거죠 ㅎㅎ 감사합니다 테오~ 😄
// then | ||
assertThat(contentsWithFilter.content().size()).isEqualTo(1); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트까지.. 💯
관련 이슈
구현 기능 및 변경 사항