-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events page #265
base: main
Are you sure you want to change the base?
Events page #265
Conversation
β¦into 263-events-page
|
||
.events-cards::-webkit-scrollbar-thumb { | ||
background-color: #e8e8cd; | ||
height: 10rem !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the way you're handling it π©·. Later on we'll see how to remove the !important from the project. Its use is considered bad practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Mayra, I use fullcalendar in fflow, and I regularly have to spend time tracking down the magic incantation that means I can avoid important. Happy for this PR to merge as is, and fix up the !importants in a separate PR.
@@ -1,48 +1,54 @@ | |||
import React from 'react'; | |||
import PropTypes from 'prop-types'; | |||
import meetup from '../../../assets/images/meetup.jpg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this MeetUp page hasn't yet been (fully) styled to match the figma designs, I assume intentional. Happy to keep it for a separate issue.
<div className="page-title-calendar"> | ||
<h1 className="font-besley text-2xl font-bold mb-2">Upcoming Events</h1> | ||
<p> | ||
<a href="/join-us">Register </a>to stay updated with upcoming events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest add "and be sent meeting invitations"
{loading ? ( | ||
<p>Loading events...</p> | ||
) : meetups.length === 0 ? ( | ||
<p>No events available</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β€οΈ
<div | ||
id={event.id} | ||
key={event.id} | ||
className={`event-card ${index % 2 === 0 ? 'yellow' : 'green'}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option to do the striping in CSS with nth-child. It's fine this way too.
} | ||
} | ||
|
||
@media (min-width: 850px) and (max-width: 1024px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are potential styling gaps here betwen 767 and 850px, and betwee 1024 and 1094px. An easy way to resolve is just only one of min or max width, not both.
Changes Implemented in this section:
π An interactive calendar to display upcoming events.
- β Integrated FullCalendar for displaying upcoming events dynamically.
-
π A past meetups section with summaries and links to resources.
- β Designed a past meetups section styled as per the Figma mockup.
π± Responsive design ensuring functionality across desktop and mobile.
β Ensured hover/click interactions for detailed event information.
β Optimized performance with lazy loading for past meetups.
Notes


Further enhancements (if needed) can be added based on feedback.
Open to suggestions on improving performance or interactivity.