Faster attribute lookup #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
force-pushed
the
attr-lookup
branch
2 times, most recently
from
d202ea3 to
779b2ec
Compare
When an attribute lookup fails, Python spends a significant chunk of CPU cycles formatting and then raising an exception. The ``nb::getattr(object, key, default)`` API provides a fallback ``default`` value in the case of an error. The expense of raising an exception is therefore not wanted here. This commit avoids this exception by - using the new ``PyObject_GetOptionalAttr()`` function on Python 3.13+ - using an internal ``_PyObject_LookupAttr()`` API before Python 3.13. - on the 3.12 stable API, using ``PyObject_HasAttr()`` before doing the lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an attribute lookup fails, Python spends a significant chunk of CPU cycles formatting and then raising an exception.
The
nb::getattr(object, key, default)API provides a fallbackdefaultvalue in the case of an error. The expense of raising an exception is therefore not wanted here.This commit avoids this exception by
PyObject_GetOptionalAttr()function on Python 3.13+_PyObject_LookupAttr()API before Python 3.13.PyObject_HasAttr()before doing the lookup.