[Installer] add back button into installer Welcome page
#993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythcoiner
changed the title
Welcome page
pythcoiner
force-pushed
the
issue_306
branch
2 times, most recently
from
a5bd001 to
bcaa28b
Compare
jp1ac4
reviewed
Mar 8, 2024
There was a problem hiding this comment.
I've tested this locally and it's working nicely, with the Back button only shown if I don't pass the network by command line.
I've added a couple of comments, but I think @edouardparis will be able to judge better the approach.
Maybe the line below the three "Select" buttons, in the same style as the select buttons, centered? |
you mean move here?
|
|
I meant below.
…On Sunday, March 10th, 2024 at 11:28 PM, pythcoiner ***@***.***> wrote:
>> (any advice welcome)
>
> Maybe the line below the three "Select" buttons, in the same style as the select buttons, centered?
you mean move here?
[image.png (view on web)](https://github.com/wizardsardine/liana/assets/124568858/6ecfb6b3-46bf-40f1-81c9-a7efafaea0da)
—
Reply to this email directly, [view it on GitHub](#993 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FZGIHI4TXPWKTLCFJ3YXTM7RAVCNFSM6AAAAABEES2Q52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGM4DGNJVGA).
You are receiving this because you commented.Message ID: ***@***.***>
|
|
here the
|
|
This has been done in #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #306
i'm not really satisfied about the button position (any advice welcome), but at leat its functionnal.