[GUI] fixed size/position for PSBT badges #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythcoiner
force-pushed
the
issue_509
branch
from
08f5711 to
66f392c
Compare
|
I like how this looks now. Should we use this new badge size also when viewing an individual PSBT?
|
|
i'm not sure anyone notice this change on psbt, as the badge in alone in the top right corner, but we can |
|
The before/after screenshots look amazing. |
edouardparis
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
ACK e05e421
I did a little refac to remove the need for _sized method. Thanks for the idea and the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR try to fix #509
i refactored some badges , moving (optional)
batchbadge before mandatory ones and give fixed positions/size for mandatory badgesbefore:
after: