gui: prevent spend with duplicate addresses

gui/src/app/state/spend/step.rs

@@ -170,22 +170,28 @@ impl DefineSpend {
             && self.recipients.iter().all(|r| r.valid())
     }
 
-    fn check_valid(&mut self) {
-        self.is_valid =
-            self.form_values_are_valid() && self.coins.iter().any(|(_, selected)| *selected);
-        self.is_duplicate = false;
+    fn exists_duplicate(&self) -> bool {
         for (i, recipient) in self.recipients.iter().enumerate() {
-            if !self.is_duplicate && !recipient.address.value.is_empty() {
-                self.is_duplicate = self.recipients[..i]
+            if !recipient.address.value.is_empty()
+                && self.recipients[..i]
                     .iter()
-                    .any(|r| r.address.value == recipient.address.value);
+                    .any(|r| r.address.value == recipient.address.value)
+            {
+                return true;
             }
         }
+        false
+    }
+
+    fn check_valid(&mut self) {
+        self.is_valid =
+            self.form_values_are_valid() && self.coins.iter().any(|(_, selected)| *selected);
+        self.is_duplicate = self.exists_duplicate();
     }
     /// redraft calculates the amount left to select and auto selects coins
     /// if the user did not select a coin manually
     fn redraft(&mut self, daemon: Arc<dyn Daemon + Sync + Send>) {
-        if !self.form_values_are_valid() || self.recipients.is_empty() {
+        if !self.form_values_are_valid() || self.exists_duplicate() || self.recipients.is_empty() {
             return;
         }
 

gui/src/app/view/spend/mod.rs

@@ -253,7 +253,7 @@ pub fn create_spend_tx<'a>(
                             .width(Length::Fixed(100.0)),
                     )
                     .push(
-                        if is_valid
+                        if is_valid && !duplicate
                             && (is_self_send
                                 || (total_amount < *balance_available
                                     && Some(&Amount::from_sat(0)) == amount_left))