Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: prevent spend with duplicate addresses #971

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Feb 22, 2024

Currently, if duplicate addresses are entered when creating a new spend, the user can click Next and only the second amount will be used for the draft PSBT.

This change prevents the user clicking Next if there are duplicate addresses and stops the redraft function running.

Previously, if duplicate addresses were entered when creating
a new spend, the user could click Next and only the second
amount would be used for the draft PSBT.

This prevents the user clicking Next if there are duplicate
addresses and stops the redraft function running.
Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manage to go to next step with two same addresses
ACK 8639f9b

@edouardparis edouardparis merged commit 903328f into wizardsardine:master Feb 22, 2024
18 checks passed
@jp1ac4 jp1ac4 deleted the gui-prevent-duplicate-payment-addresses branch February 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants