gui: add listcoins filters
#967
Conversation
|
Beware that the application use the Coins message passing by to update its cache: One of the main advantages of the new list_coins filter is the outpoints filter, we should use it in the daemon methods that retrieve the coins which outpoints are corresponding to the inputs and the outputs of the resulting HistoryTransaction, Psbt etc |
jp1ac4
force-pushed
the
gui-add-listcoins-filters
branch
from
0391903 to
3419df1
Compare
| // TODO: filter for the outpoints in `tx.coins` when this is possible: | ||
| // https://github.com/wizardsardine/liana/issues/677 | ||
| .list_coins() | ||
| .list_coins(&[CoinStatus::Spending], &outpoints) |
There was a problem hiding this comment.
we use the outpoint, it is enough, you can remove the status filter. My fear is that the coin exists, just is not yet marked as spending
There was a problem hiding this comment.
I think it's OK to keep the status filter here as the previous filter_map was already filtering for coins with a non-null spend txid.
There was a problem hiding this comment.
Ah you may right, I think we are good then.
| // TODO: filter for spending coins when this is possible: | ||
| // https://github.com/wizardsardine/liana/issues/677 | ||
| .list_coins() | ||
| .list_coins(&[CoinStatus::Spending], &outpoints) |
There was a problem hiding this comment.
we use the outpoint, it is enough, you can remove the status filter. My fear is that the coin exists, just is not yet marked as spending
There was a problem hiding this comment.
As with the other comment, I've kept the status filter.
jp1ac4
force-pushed
the
gui-add-listcoins-filters
branch
from
3419df1 to
1c99376
Compare
This is to resolve #677.
As well as adding the filters to the daemon interface, I've applied filters in separate commits to different sections of the GUI.
This PR builds on changes from #958 and #965. The latter is required when filtering for pending transactions so that a coin whose spending txid changes (e.g. due to RBF) remains as spending.