Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get genesis timestamp from bitcoind #957

Merged

Conversation

pythcoiner
Copy link
Collaborator

fixes #904

@pythcoiner pythcoiner force-pushed the genesis_timestamp_from_bitcoind branch from 2b212d4 to 435605a Compare February 3, 2024 06:22
@pythcoiner pythcoiner changed the title get genesis timestamp from bitcoind [WIP]get genesis timestamp from bitcoind Feb 3, 2024
@pythcoiner pythcoiner force-pushed the genesis_timestamp_from_bitcoind branch 2 times, most recently from cd13f09 to 3eef53d Compare February 3, 2024 07:41
assert 'timestamp' in res.keys()
assert "timestamp" in res.keys()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black doing is job here

match=re.escape(
"A feerate must not be provided if creating a cancel."
),
match=re.escape("A feerate must not be provided if creating a cancel."),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black doing his job

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Feb 7, 2024

Is this still WIP?

@pythcoiner pythcoiner changed the title [WIP]get genesis timestamp from bitcoind Get genesis timestamp from bitcoind Feb 8, 2024
@pythcoiner
Copy link
Collaborator Author

Is this still WIP?

updated title

Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3eef53d.

@pythcoiner pythcoiner force-pushed the genesis_timestamp_from_bitcoind branch from 3eef53d to f2c418f Compare February 11, 2024 01:02
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f2c418f.

@darosior darosior merged commit cf299b9 into wizardsardine:master Mar 9, 2024
18 checks passed
@pythcoiner pythcoiner deleted the genesis_timestamp_from_bitcoind branch March 26, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startrescan allows timestamps before genesis block on test networks
3 participants