Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when importing desc for wrong network #933

Conversation

edouardparis
Copy link
Member

close #781

@edouardparis edouardparis requested a review from jp1ac4 January 23, 2024 15:43
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed 04e9d9d and left a comment regarding the message wording.

@edouardparis edouardparis force-pushed the fix-781-error-message-for-wrong-desc-network branch from 04e9d9d to 24f67d2 Compare January 24, 2024 12:48
Copy link
Member Author

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-ACK 24f67d2

@edouardparis edouardparis merged commit 5a56fdb into wizardsardine:master Jan 24, 2024
18 checks passed
@edouardparis edouardparis deleted the fix-781-error-message-for-wrong-desc-network branch January 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: Installer: clearer error on descriptor import for wrong network
3 participants