Reset bitcoind default settings on network change

[edouardparis]

close #812

[edouardparis]

Self-ACK 8146269

[jp1ac4]

ACK 8146269.

I've just realised we have a panic if the user does the same when using the managed bitcoind:

ERROR liana_gui:443: panic occurred at line 847 of file src/installer/step/bitcoind.rs: Some("Already added")

I believe we need to clear the internal bitcoind config:

diff --git a/gui/src/installer/step/bitcoind.rs b/gui/src/installer/step/bitcoind.rs
index 9f581a7..25b70b5 100644
--- a/gui/src/installer/step/bitcoind.rs
+++ b/gui/src/installer/step/bitcoind.rs
@@ -689,7 +689,10 @@ impl Step for InternalBitcoindStep {
                 self.exe_download = Some(Download::new(0));
             };
         }
-        self.network = ctx.bitcoin_config.network;
+        if self.network != ctx.bitcoin_config.network {
+            self.internal_bitcoind_config = None;
+            self.network = ctx.bitcoin_config.network;
+        }
         if let Some(Ok(_)) = self.started {
             // This case can arise if a user switches from internal bitcoind to external and back to internal.
             if ctx.bitcoind_config.is_none() {

[edouardparis]

👍 Creating a new issue for it.