ci: use bitcoind version 28.1 #1398
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nondiremanuel
added
the
Nice to have
|
I'm able to reproduce the failing tests locally. It seems that electrs v0.9.11 doesn't work with bitcoind v28.0, but more recent electrs versions do. I'll need to make a more recent electrs binary available and then use this in the CI. |
|
I've created RCasatta/electrsd#86 to build a more recent electrs binary. |
nondiremanuel
modified the milestones:
v8 Liana - UI fixes and other,
v9 Liana - UI fixes and other
jp1ac4
force-pushed
the
ci-use-bitcoind-28.0
branch
from
1bebadc to
9c30b31
Compare
|
Error in logs: Perhaps an update to the Docker image is required. |
nondiremanuel
modified the milestones:
v9 Liana - UI fixes and other,
v10 Liana - UI fixes and other activities
jp1ac4
added a commit
to jp1ac4/electrsd
that referenced
this pull request
Jan 31, 2025
This is in order to use an older GLIBC version so that the binary can be used in CI functional tests for Liana wallet. wizardsardine/liana#1398 (comment)
jp1ac4
force-pushed
the
ci-use-bitcoind-28.0
branch
from
eb44b22 to
4fd5ff7
Compare
jp1ac4
force-pushed
the
ci-use-bitcoind-28.0
branch
from
c7c0681 to
708bb3a
Compare
|
Using the same bitcoind and electrs versions as used by CI, I wasn't able to reproduce the failing test. |
jp1ac4
force-pushed
the
ci-use-bitcoind-28.0
branch
from
708bb3a to
c17e945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1397.