store "max sane feerate" in config file instead hardcoding it

[pythcoiner]

following my comment here, i think we should store this value in the config file instead of hardcoding it as we already see many tx w/ a feerate > 1000sats/vb

(I do not check if it has already been tackled in the lasts commits of v4)

[kloaec]

I opened this, as it's related:
#910

[pythcoiner]

looking at this, in spend.rs we have several constants defined:

/// We would never create a transaction with an output worth less than this.
/// That's 1$ at 20_000$ per BTC.
pub const DUST_OUTPUT_SATS: u64 = 5_000;

/// Long-term feerate (sats/vb) used for coin selection considerations.
pub const LONG_TERM_FEERATE_VB: f32 = 10.0;

/// Assume that paying more than 1BTC in fee is a bug.
pub const MAX_FEE: bitcoin::Amount = bitcoin::Amount::ONE_BTC;

/// Assume that paying more than 1000sat/vb in feerate is a bug.
pub const MAX_FEERATE: u64 = 1_000;

should we move all in the config file instead?

[pythcoiner]

@darosior

[darosior]

Sure we can make the dust output sat, max fee, max feerate and long term feerate configurable.

[edouardparis]

I am using this thread to give an opinion about configuration: I think we should not use the configuration file for this kind of values but use the wallet table and change them using a new command. It will help us long term for the multiple wallet support and it enable "on the fly" change of the dust value by the client without having to restart the daemon.

[pythcoiner]

I am using this thread to give an opinion about configuration: I think we should not use the configuration file for this kind of values but use the wallet table and change them using a new command. It will help us long term for the multiple wallet support and it enable "on the fly" change of the dust value by the client without having to restart the daemon.

you mean have some way from GUI (in settings) to allow user to change?