gui(psbt): check for conflicting txs before broadcast

Author: jp1ac4

gui/src/app/state/psbt.rs

@@ -8,7 +8,7 @@ use iced::Subscription;
 use iced::Command;
 use liana::{
     descriptors::LianaPolicy,
-    miniscript::bitcoin::{bip32::Fingerprint, psbt::Psbt, Network},
+    miniscript::bitcoin::{bip32::Fingerprint, psbt::Psbt, Network, Txid},
 };
 
 use liana_ui::component::toast;
@@ -172,7 +172,16 @@ impl PsbtState {
                     return cmd;
                 }
                 view::SpendTxMessage::Broadcast => {
-                    self.action = Some(PsbtAction::Broadcast(BroadcastAction::default()));
+                    let conflicting_txids: HashSet<_> = self
+                        .tx
+                        .coins
+                        .iter()
+                        .filter_map(|(_, c)| c.spend_info.map(|info| info.txid))
+                        .collect();
+                    self.action = Some(PsbtAction::Broadcast(BroadcastAction {
+                        conflicting_txids,
+                        ..Default::default()
+                    }));
                 }
                 view::SpendTxMessage::Save => {
                     self.action = Some(PsbtAction::Save(SaveAction::default()));
@@ -290,6 +299,8 @@ impl Action for SaveAction {
 pub struct BroadcastAction {
     broadcast: bool,
     error: Option<Error>,
+    /// IDs of any directly conflicting transactions.
+    conflicting_txids: HashSet<Txid>,
 }
 
 impl Action for BroadcastAction {
@@ -327,7 +338,11 @@ impl Action for BroadcastAction {
     fn view<'a>(&'a self, content: Element<'a, view::Message>) -> Element<'a, view::Message> {
         modal::Modal::new(
             content,
-            view::psbt::broadcast_action(self.error.as_ref(), self.broadcast),
+            view::psbt::broadcast_action(
+                &self.conflicting_txids,
+                self.error.as_ref(),
+                self.broadcast,
+            ),
         )
         .on_blur(Some(view::Message::Spend(view::SpendTxMessage::Cancel)))
         .into()

gui/src/app/view/psbt.rs

@@ -140,7 +140,15 @@ pub fn save_action<'a>(warning: Option<&Error>, saved: bool) -> Element<'a, Mess
     }
 }
 
-pub fn broadcast_action<'a>(warning: Option<&Error>, saved: bool) -> Element<'a, Message> {
+/// Return the modal view to broadcast a transaction.
+///
+/// `conflicting_txids` contains the IDs of any directly conflicting transactions
+/// of the transaction to be broadcast.
+pub fn broadcast_action<'a>(
+    conflicting_txids: &HashSet<Txid>,
+    warning: Option<&Error>,
+    saved: bool,
+) -> Element<'a, Message> {
     if saved {
         card::simple(text("Transaction is broadcast"))
             .width(Length::Fixed(400.0))
@@ -151,15 +159,71 @@ pub fn broadcast_action<'a>(warning: Option<&Error>, saved: bool) -> Element<'a,
             Column::new()
                 .spacing(10)
                 .push_maybe(warning.map(|w| warn(Some(w))))
-                .push(text("Broadcast the transaction"))
+                .push(Container::new(h4_bold("Broadcast the transaction")).width(Length::Fill))
+                .push_maybe(if conflicting_txids.is_empty() {
+                    None
+                } else {
+                    Some(
+                        conflicting_txids.iter().fold(
+                            Column::new()
+                                .spacing(5)
+                                .push(Row::new().spacing(10).push(icon::warning_icon()).push(text(
+                                    if conflicting_txids.len() > 1 {
+                                        "WARNING: Broadcasting this transaction \
+                                        will invalidate some pending payments."
+                                    } else {
+                                        "WARNING: Broadcasting this transaction \
+                                        will invalidate a pending payment."
+                                    },
+                                )))
+                                .push(Row::new().padding([0, 30]).push(text(
+                                    if conflicting_txids.len() > 1 {
+                                        "The following transactions are \
+                                        spending one or more inputs \
+                                        from the transaction to be \
+                                        broadcast and will be \
+                                        dropped, along with any other \
+                                        transactions that depend on them:"
+                                    } else {
+                                        "The following transaction is \
+                                        spending one or more inputs \
+                                        from the transaction to be \
+                                        broadcast and will be \
+                                        dropped, along with any other \
+                                        transactions that depend on it:"
+                                    },
+                                ))),
+                            |col, txid| {
+                                col.push(
+                                    Row::new()
+                                        .padding([0, 30])
+                                        .spacing(5)
+                                        .align_items(Alignment::Center)
+                                        .push(text(txid.to_string()))
+                                        .push(
+                                            Button::new(
+                                                icon::clipboard_icon().style(color::GREY_3),
+                                            )
+                                            .on_press(Message::Clipboard(txid.to_string()))
+                                            .style(theme::Button::TransparentBorder),
+                                        ),
+                                )
+                            },
+                        ),
+                    )
+                })
                 .push(
                     Row::new().push(Column::new().width(Length::Fill)).push(
                         button::primary(None, "Broadcast")
                             .on_press(Message::Spend(SpendTxMessage::Confirm)),
                     ),
                 ),
         )
-        .width(Length::Fixed(400.0))
+        .width(Length::Fixed(if conflicting_txids.is_empty() {
+            400.0
+        } else {
+            800.0
+        }))
         .into()
     }
 }