Skip to content

Commit 7086124

Browse files
committed
qa: drop specific value assertions in coin selection test
They don't add much value and cause flakiness because the size might sometimes be lower than that due to low-R signature grinding.
1 parent 110e8f2 commit 7086124

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

tests/test_spend.py

-7
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,6 @@ def additional_fees(anc_vsize, anc_fee, target_feerate):
335335
)
336336
anc_vsize = bitcoind.rpc.getmempoolentry(spend_txid_1)["ancestorsize"]
337337
anc_fees = int(bitcoind.rpc.getmempoolentry(spend_txid_1)["fees"]["ancestor"] * COIN)
338-
if not USE_TAPROOT:
339-
assert anc_vsize == 161 and anc_fees == 339
340338
additional_fee = additional_fees(anc_vsize, anc_fees, feerate)
341339
assert len(spend_res_2["warnings"]) == 1
342340
assert (
@@ -355,8 +353,6 @@ def additional_fees(anc_vsize, anc_fee, target_feerate):
355353
)
356354
anc_vsize = bitcoind.rpc.getmempoolentry(spend_txid_1)["ancestorsize"]
357355
anc_fees = int(bitcoind.rpc.getmempoolentry(spend_txid_1)["fees"]["ancestor"] * COIN)
358-
if not USE_TAPROOT:
359-
assert anc_vsize == 161 and anc_fees == 339
360356
additional_fee = additional_fees(anc_vsize, anc_fees, feerate)
361357
assert len(spend_res_2["warnings"]) == 1
362358
assert (
@@ -403,9 +399,6 @@ def additional_fees(anc_vsize, anc_fee, target_feerate):
403399
anc_fees = int(bitcoind.rpc.getmempoolentry(deposit_2)["fees"]["ancestor"] * COIN)
404400
prev_anc_vsize = bitcoind.rpc.getmempoolentry(spend_txid_1)["ancestorsize"]
405401
prev_anc_fees = int(bitcoind.rpc.getmempoolentry(spend_txid_1)["fees"]["ancestor"] * COIN)
406-
if not USE_TAPROOT:
407-
assert anc_vsize == anc_fees == 165
408-
assert prev_anc_vsize == 161 and prev_anc_fees == 339
409402
additional_fee = additional_fees(anc_vsize, anc_fees, feerate) + additional_fees(prev_anc_vsize, prev_anc_fees, feerate)
410403
assert len(spend_res_3["warnings"]) == 1
411404
assert (

0 commit comments

Comments
 (0)