Improve IDX template configuration #91
Conversation
✅ Deploy Preview for astro-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fryuni
force-pushed
the
Fryuni-patch-1
branch
from
1bb564a to
c23bf66
Compare
There was a problem hiding this comment.
Just the small issue with the onCreate behaviour, after the successful execution of idx environment. This is a great improvement, time to deployment was significantly faster as a result of these mods.
Great work @Fryuni
💚
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "recommendations": [], | |||
| "unwantedRecommendations": ["astro-build.astro-vscode"] | |||
There was a problem hiding this comment.
I’m assuming this is related to the workaround in the dev.nix file? Or is it left over from some experiments? (On the surface it seems odd to mark the Astro extension as unwanted.)
There was a problem hiding this comment.
It is! IDX will show the popup recommending to install the Astro extension while it is already being installed. This is to skip that popup. I'd add a comment, but can't have those in this file.
There was a problem hiding this comment.
OK, cool — thank you! This PR and your comment here will serve as our reference for future adventurers 🫡
| ''; | ||
| in '' | ||
| # Timeout for the whole bootstrap script | ||
| timeout -k 30s 30s ${script} |
There was a problem hiding this comment.
How long do you think bootstrap will normally take? What’s the likelihood of it exceeding 30 seconds? Would be good to make sure we’re not too close to a regular run time, so we don’t kill a project just because bootstrapping took 32 seconds.
There was a problem hiding this comment.
Most of the time will be spent installing create-astro and creating the project. On Google's network that takes about 5s:
The remaining time spent on initialization is on Nix downloading and configuring Node and pnpm before calling bootstrap.
Try the template from this branch clicking here: