Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump core crypto to 3.0.1 [WPB-15765] 🍒 #3258

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 28, 2025

TaskWPB-15765 [Android] bump corecrypto to 3.0.1

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

bump core crypto to 3.0.1

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch type: chore 🧹 👕 size: XS labels Jan 28, 2025
Copy link
Contributor Author

github-actions bot commented Jan 29, 2025

Test Results

3 410 tests  ±0   3 302 ✅ ±0   6m 2s ⏱️ -4s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit 298036a. ± Comparison against base commit f4afb2a.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 29, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.90%. Comparing base (f4afb2a) to head (298036a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3258      +/-   ##
===========================================
- Coverage    53.90%   53.90%   -0.01%     
===========================================
  Files         1303     1303              
  Lines        37396    37396              
  Branches      3770     3770              
===========================================
- Hits         20159    20157       -2     
- Misses       15828    15830       +2     
  Partials      1409     1409              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4afb2a...298036a. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/update-cc-cherry-pick
Commit report: 9152087
Test service: kalium-jvm

✅ 0 Failed, 3302 Passed, 108 Skipped, 1m 2.86s Total Time

Merged via the queue into develop with commit 952e034 Jan 29, 2025
23 checks passed
@MohamadJaara MohamadJaara deleted the chore/update-cc-cherry-pick branch January 29, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants