fix: set default type to "internal" if it's somehow missing

winteragency · May 6, 2024 · 1839f3b · 1839f3b
1 parent 35ff362
commit 1839f3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/components/LinkTypeInput.tsx b/src/components/LinkTypeInput.tsx
@@ -5,6 +5,7 @@ import {set, type StringInputProps} from 'sanity'
 import styled from 'styled-components'
 
 import {CustomLinkType, LinkFieldPluginOptions, LinkType} from '../types'
+import {useEffect} from 'react'
 
 const defaultLinkTypes: LinkType[] = [
   {title: 'Internal', value: 'internal', icon: LinkIcon},
@@ -52,6 +53,13 @@ export function LinkTypeInput({
 
   const selectedType = linkTypes.find((type) => type.value === value) || linkTypes[0]
 
+  useEffect(() => {
+    // Make sure there's always a default value
+    if (!value) {
+      onChange(set('internal'))
+    }
+  }, [onChange, value])
+
   return (
     <MenuButton
       button={

diff --git a/src/helpers/typeGuards.ts b/src/helpers/typeGuards.ts
@@ -16,4 +16,4 @@ export const isEmailLink = (link: LinkValue): link is EmailLink => link.type ===
 export const isPhoneLink = (link: LinkValue): link is PhoneLink => link.type === 'phone'
 
 export const isCustomLink = (link: LinkValue): link is CustomLink =>
-  !['internal', 'external', 'email', 'phone'].includes(link.type)
+  !!link.type && !['internal', 'external', 'email', 'phone'].includes(link.type)