Refactor client spec to remove sleep statements #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using random sleep values, add a `wait_for` helper method, which efficiently waits until async operations have changed the expected variables before running the assertions. closes wilsonsilva#5
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
PR Overview
This PR refactors the asynchronous test suite for the Nostr::Client by replacing arbitrary sleep statements with a more reliable wait_for helper method.
- Removes sleep statements throughout the spec.
- Introduces a wait_for helper to actively wait for desired conditions before assertions.
Reviewed Changes
| File | Description |
|---|---|
| spec/nostr/client_spec.rb | Replaces sleeps with wait_for for better async operation tests. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
spec/nostr/client_spec.rb:315
- [nitpick] Consider storing the result of block.call in a variable before the conditional check to avoid evaluating the block twice, which could lead to unintended side effects if the block has stateful behavior.
raise 'Condition not met within timeout' unless block.call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using random sleep values, add a
wait_forhelper method, which efficiently waits until async operations have changed the expected variables before running the assertions.There was one spec, which would occasionally fail with the arbitrary sleep value, and which works reliably now. And because the sleep value for the
wait_forloop is much lower, the specs are also considerably faster now.closes #5