Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle absolute paths on windows #90

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

alex-tdrn
Copy link
Contributor

Hello, absolute paths on windows weren't being identified.
Aside from that, everything works flawlessly on windows. Amazing plugin, thank you ✨

@willothy
Copy link
Owner

Thanks for the PR! Glad you like the plugin :)

Copy link
Owner

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I appreciate cross-platform fixes a lot since I don't have a Windows setup to test on :)

@willothy willothy merged commit d1fff3c into willothy:main Jan 25, 2024
2 of 3 checks passed
@kjuq
Copy link
Contributor

kjuq commented Jan 26, 2024

vim.fn.has() returns 0|1 but these are always treated as true in lua. So we should check that by vim.fn.has("win32") == 1.
It's fixed at #92.

@willothy
Copy link
Owner

vim.fn.has() returns 0|1 but these are always treated as true in lua. So we should check that by vim.fn.has("win32") == 1.

It's fixed at #92.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants