[FIX] RankStatsFragment ISE fix candidate #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in RankStatsFragment which makes this feel a little bit like overkill.
uhtu
approved these changes
Jan 23, 2024
| @@ -526,15 +530,15 @@ public void handleDialog(final int dialogId) { | |||
| if (!exportM8bFile()) { | |||
| Logging.warn("Failed to export m8b."); | |||
| WiGLEToast.showOverFragment(getActivity(), R.string.error_general, | |||
| getString(R.string.m8b_failed)); | |||
| getActivity().getResources().getString(R.string.m8b_failed)); | |||
There was a problem hiding this comment.
is there a reason to be more confident about this getActivity not returning null (contra :466)?
| @@ -126,7 +126,10 @@ public void onAuthenticationRequired() { | |||
| public void onTaskCompleted() { | |||
| stopAnimation(); | |||
| if (userDownloadFailed) { | |||
| WiGLEToast.showOverFragment(a, R.string.upload_failed, getString(R.string.dl_failed)); | |||
| if (null != a) { | |||
There was a problem hiding this comment.
i think a was already nullchecked at :113 ?
There was a problem hiding this comment.
quite right - I was being cautious because it's in a callback, but the reference is final, it'll be fine.
bobzilladev
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's a pass at making all these safe. the only reported exception is in RankStatsFragment which makes this feel a little bit like overkill, but there's reason to believe we're taking this risk in multiple places.