From 90f6ce143504bde5e54e57885bf4f19b55bb684d Mon Sep 17 00:00:00 2001
From: Faisal N Jawdat <faisal@faisal.com>
Date: Thu, 30 Jan 2025 21:09:18 +0000
Subject: [PATCH] CHANGE: bump rubocop to 1.7.3, adopt new plugins config, fix
 cop-found issue

---
 .rubocop.yml                                       | 2 +-
 lib/rubycritic/source_control_systems/mercurial.rb | 3 ++-
 rubycritic.gemspec                                 | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 97393f47..1928c2f7 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rake
diff --git a/lib/rubycritic/source_control_systems/mercurial.rb b/lib/rubycritic/source_control_systems/mercurial.rb
index 0303a355..09ee755d 100644
--- a/lib/rubycritic/source_control_systems/mercurial.rb
+++ b/lib/rubycritic/source_control_systems/mercurial.rb
@@ -6,7 +6,8 @@ class Mercurial < Base
       register_system
 
       def self.supported?
-        `hg verify 2>&1` && $CHILD_STATUS.success?
+        hg_verify = `hg verify 2>&1`
+        hg_verify && $CHILD_STATUS.success?
       end
 
       def self.to_s
diff --git a/rubycritic.gemspec b/rubycritic.gemspec
index c7d01080..620569cd 100644
--- a/rubycritic.gemspec
+++ b/rubycritic.gemspec
@@ -61,7 +61,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 13.2.0', '>= 11.0.0'
   spec.add_development_dependency 'rdoc'
   spec.add_development_dependency 'rexml', '>= 3.2.0'
-  spec.add_development_dependency 'rubocop', '~> 1.70.0', '>= 1.54.0'
+  spec.add_development_dependency 'rubocop', '~> 1.73.2', '>= 1.72.0'
   spec.add_development_dependency 'rubocop-minitest'
   spec.add_development_dependency 'rubocop-performance'
   spec.add_development_dependency 'rubocop-rake'