CHANGE: bump rubocop to 1.7.3, adopt new plugins config, fix cop-foun…

…d issue
whitesmith · Mar 4, 2025 · 90f6ce1 · 90f6ce1
1 parent fd4a1e5
commit 90f6ce1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rake

diff --git a/lib/rubycritic/source_control_systems/mercurial.rb b/lib/rubycritic/source_control_systems/mercurial.rb
@@ -6,7 +6,8 @@ class Mercurial < Base
       register_system
 
       def self.supported?
-        `hg verify 2>&1` && $CHILD_STATUS.success?
+        hg_verify = `hg verify 2>&1`
+        hg_verify && $CHILD_STATUS.success?
       end
 
       def self.to_s

diff --git a/rubycritic.gemspec b/rubycritic.gemspec
@@ -61,7 +61,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 13.2.0', '>= 11.0.0'
   spec.add_development_dependency 'rdoc'
   spec.add_development_dependency 'rexml', '>= 3.2.0'
-  spec.add_development_dependency 'rubocop', '~> 1.70.0', '>= 1.54.0'
+  spec.add_development_dependency 'rubocop', '~> 1.73.2', '>= 1.72.0'
   spec.add_development_dependency 'rubocop-minitest'
   spec.add_development_dependency 'rubocop-performance'
   spec.add_development_dependency 'rubocop-rake'