Update 'Creating a sequence from an iterable' to use new iterator AOs #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
changed the title
annevk
reviewed
Jun 10, 2024
| 1. Let |next| be [=?=] <a abstract-op>IteratorStep</a>(|iter|). | ||
| 1. If |next| is <emu-val>false</emu-val>, | ||
| 1. Let |next| be [=?=] <a abstract-op>IteratorStepValue</a>(|iteratorRecord|). | ||
| 1. If |next| is <emu-const>done</emu-const>, |
There was a problem hiding this comment.
Should this be uppercase DONE as is done in JS?
There was a problem hiding this comment.
No, that's a visual choice they apply via CSS in the default ecmarkup stylesheet:
annevk
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetIteratorno longer exists in this form (it tries to obtain the method when passedsyncorasync), andIteratorStep/IteratorValuehave been merged into a single AO for convenience.Preview | Diff