Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream XMLSerializer from DOM Parsing spec #11077

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Upstream XMLSerializer from DOM Parsing spec #11077

merged 3 commits into from
Feb 28, 2025

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Feb 26, 2025 •
edited by pr-preview bot
Loading

Upstream XMLSerializer from DOM Parsing spec

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/dynamic-markup-insertion.html ( diff )
/index.html ( diff )

@lukewarlow lukewarlow mentioned this pull request Feb 26, 2025
Closed
5 tasks
@lukewarlow lukewarlow force-pushed the xmlserialiser-interface branch from d1f39fe to ff73ffc Compare February 26, 2025 19:31
@lukewarlow
Copy link
Member Author

Spec PR for DOM Parsing to remove this w3c/DOM-Parsing#87

@lukewarlow lukewarlow requested a review from domenic February 26, 2025 20:57
annevk
annevk reviewed Feb 27, 2025
View reviewed changes
@lukewarlow lukewarlow force-pushed the xmlserialiser-interface branch from ff73ffc to 2fa063d Compare February 27, 2025 11:21
annevk
annevk approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good editorially. I'll let @domenic do the final take as I'm not sure what kind of requirements he had in mind for partial upstreaming.

domenic
domenic approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the nit and merge. Thanks!

source

<ol>
<li><p>Return the <span data-x="xml-serialization">XML serialization</span> of <var>root</var>
given <var>false</var>.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false is not a variable.

@domenic domenic merged commit 2edb8cc into whatwg:main Feb 28, 2025
2 checks passed
domenic pushed a commit to w3c/DOM-Parsing that referenced this pull request Feb 28, 2025
@lukewarlow
Remove XMLSerializer interface
9127361 
This has been moved to the HTML Standard in whatwg/html#11077.
@lukewarlow lukewarlow deleted the xmlserialiser-interface branch February 28, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewarlow @domenic @annevk