Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Button and Input Activation behaviours #11053

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Update Button and Input Activation behaviours #11053

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea2ab54
Update Button and Input Activation behaviours
lukewarlow Feb 20, 2025
4bfab38
Move steps higher up
lukewarlow Feb 20, 2025
8bcbbf9
Add early returns
lukewarlow Feb 20, 2025
11b60e6
Add early return for auto state buttons
lukewarlow Feb 20, 2025
115bc00
Address comments
lukewarlow Feb 25, 2025
81b178b
Add indent to comment and remove newline
lukewarlow Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48262,6 +48262,10 @@ interface <dfn interface>HTMLInputElement</dfn> : <span>HTMLElement</span> {
<li><p>Run <var>element</var>'s <dfn>input activation behavior</dfn>, if any, and do nothing
otherwise.</p></li>

<li><p>If <var>element</var> has a <span>form owner</span> and <var>element</var>'s <span
data-x="attr-input-type">type</span> attribute is not in the <span
data-x="attr-input-type-button">Button</span> state, then return.</p></li>

<li><p>Run the <span>popover target attribute activation behavior</span> given <var>element</var>
and <var>event</var>'s <span data-x="concept-event-target">target</span>.</p></li>
</ol>
Expand Down Expand Up @@ -53599,12 +53603,17 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> {
then <span data-x="concept-form-submit">submit</span> <var>element</var>'s
<span>form owner</span> from <var>element</var> with <i
data-x="submit-user-involvement">userInvolvement</i> set to <var>event</var>'s <span
data-x="event-uni">user navigation involvement</span>.</p></li>
data-x="event-uni">user navigation involvement</span>, and return.</p></li>

<li><p>If <var>element</var>'s <code data-x="attr-button-type">type</code> attribute is in the
<span data-x="attr-button-type-reset-state">Reset Button</span> state, then <span
data-x="concept-form-reset">reset</span> <var>element</var>'s
<span>form owner</span>.</p></li>
data-x="concept-form-reset">reset</span> <var>element</var>'s <span>form owner</span>, and
return.</p></li>

<li><p>If <var>element</var>'s <code data-x="attr-button-type">type</code> attribute is in the
<span data-x="attr-button-type-auto-state">Auto</span> state, then return.</p></li>
<!-- We do this for compatability and plan to remove this restriction in future, see
https://github.com/whatwg/html/issues/10832 -->
</ol>
</li>

Expand All @@ -53616,10 +53625,6 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> {
<p>If <var>target</var> is not null:</p>

<ol>
<li><p>If <var>element</var> has a <span>form owner</span> and <var>element</var>'s <code
data-x="attr-button-type">type</code> attribute is in the <span
data-x="attr-button-type-submit-state">Submit Button</span> state, then return.</p></li>

<li><p>Let <var>command</var> be <var>element</var>'s <code
data-x="attr-button-command">command</code> attribute.</p></li>

Expand Down