Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEAM REVIEW] WV-481 - IssuesByBallotItemDisplayList collapsing whenever support/oppose button pressed. OfficeItemCompressed refactor. #4176

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

anewgard41
Copy link
Contributor

@anewgard41 anewgard41 commented Nov 21, 2024

What github.com/wevote/WebApp/issues does this fix?

Secondary issue pointed out in WV-481

Changes included this pull request?

  • Extracted candidate rendering logic.
  • Moved rendering to new functional component, OneOfficeCandidateList
  • Moved logic for determining which candidates to render into the getCandidatesToRender method. This method ensures that only the required number of candidates is passed down to the OneOfficeCandidateList.

… render of BallotScrollingContainer outside of OfficeItemCompressed. Simplified state management and rendering
@DaleMcGrew
Copy link
Member

@jedwardmook this would also be an excellent issue to bring to your machine, and finish. We need to make sure that the changes do not cause the loss of the existing functionality relating to chosen candidates having a green background.

@Succorro
Copy link
Contributor

@DaleMcGrew the changes made by Anders seem to be working properly. Chosen Ballot item is displaying color properly regardless of device or screen size. In addition the updated code fixed the initial issue well.

@DaleMcGrew
Copy link
Member

Thank you @anewgard41 and @Succorro for your help with this! 👍

@DaleMcGrew DaleMcGrew merged commit adfc291 into wevote:develop Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants