WV-4 Indicate primary email/phone number can't be deleted TEAM REVIEW #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included this pull request
-Add grayed-out trash can icon to primary email/phone numbers
-Add tooltip popup to trash cans with message indicating primary email/phone cannot be deleted
-Change variable name emailOwnershipIsVerified to smsOwnershipIsVerified in phone component
###Questions to address
-trash icon placement (There was originally some padding in the email component, but not the phone. I just eyeballed it with additional padding to line up with existing trash icons)
-double check that key used for div created in map is ok (I'm pretty sure it is)