Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WV-105] TEAM REVIEW Added open new window for "i'll chip in" in cordova mobile #3866

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

jpena925
Copy link
Contributor

What github.com/wevote/WebApp/issues does this fix?

Adds icon and checks if isCordova then opens new window outside of app for donations.

Changes included this pull request?

/>
</Suspense>
</CampaignSupportMobileButtonPanel>
) : (
<Button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpena925 I forgot when we met that you also have to wrap the Button in the "else" block with <CampaignSupportMobileButtonPanel>. You can also delete the "style" attribute in <Launch. Finally, OpenExternalWebsite should be included using Lazy, instead of a direct import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DaleMcGrew I made the changes here. Let me know if this works or if I should make a new PR. Thanks for the feedback and help!

@DaleMcGrew
Copy link
Member

👍

@DaleMcGrew DaleMcGrew merged commit 3520815 into wevote:develop Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants