From 076fec32b0c24655ddc28a88195a53582001749b Mon Sep 17 00:00:00 2001 From: stevepodell Date: Tue, 23 Jan 2024 15:28:41 -0800 Subject: [PATCH 1/2] Made the Twitter Account Links clickable on the Supporters' Slide-out drawer This is now the case for some responsive sizes and desktop. These links are not displayed in Cordova. Resolves https://wevoteusa.atlassian.net/browse/WV-102 --- src/js/components/Ballot/PositionItem.jsx | 25 +++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/js/components/Ballot/PositionItem.jsx b/src/js/components/Ballot/PositionItem.jsx index 89198417a..d79084e72 100644 --- a/src/js/components/Ballot/PositionItem.jsx +++ b/src/js/components/Ballot/PositionItem.jsx @@ -353,14 +353,23 @@ class PositionItem extends Component { { !!(position.twitter_followers_count && String(position.twitter_followers_count) !== '0') && ( - - - @ - {position.speaker_twitter_handle} - - - {abbreviateNumber(position.twitter_followers_count)} - + + + + @ + {position.speaker_twitter_handle} + + + {abbreviateNumber(position.twitter_followers_count)} + + + )} + linkIdAttribute="candidateTwitterDesktop" + url={`https://twitter.com/${position.speaker_twitter_handle}`} + target="_blank" + /> )} From 6423bde913f2515e01780505a4404d14eb0574dc Mon Sep 17 00:00:00 2001 From: stevepodell Date: Wed, 24 Jan 2024 09:29:58 -0800 Subject: [PATCH 2/2] Made the Twitter Account Links clickable on the Supporters' Slide-out drawer This is now the case for some responsive sizes and desktop. These links are not displayed in Cordova. Resolves https://wevoteusa.atlassian.net/browse/WV-102 --- src/js/components/Ballot/PositionItem.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/components/Ballot/PositionItem.jsx b/src/js/components/Ballot/PositionItem.jsx index d79084e72..ff05e0fe4 100644 --- a/src/js/components/Ballot/PositionItem.jsx +++ b/src/js/components/Ballot/PositionItem.jsx @@ -366,7 +366,7 @@ class PositionItem extends Component { )} - linkIdAttribute="candidateTwitterDesktop" + linkIdAttribute="positionItemTwitterDesktop" url={`https://twitter.com/${position.speaker_twitter_handle}`} target="_blank" />