Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COMP]: InView: off-screen exit animations should be instant #102

Open
andrewrubin opened this issue Jan 31, 2024 · 1 comment
Open

[COMP]: InView: off-screen exit animations should be instant #102

andrewrubin opened this issue Jan 31, 2024 · 1 comment
Assignees
@andrewrubin
Labels
COMP Tickets related to wethegit-components enhancement New feature or request
Milestone
v2

Comments

@andrewrubin
Copy link
Member

We should set the animation durations to zero for exit transitions, only when matchRootMarginToThreshold={true}.

Currently, if you have even a slight duration on your InView animations, you can quickly scroll back up and see them in a half-transitioned state.
@andrewrubin andrewrubin added enhancement New feature or request COMP Tickets related to wethegit-components labels Jan 31, 2024
@marlonmarcello marlonmarcello added this to the v2 milestone Feb 29, 2024
@andrewrubin
Copy link
Member Author

I'm going to treat this one as blocked until this issue is resolved on the wethegit/react-hooks package: wethegit/react-hooks#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewrubin andrewrubin

Labels
COMP Tickets related to wethegit-components enhancement New feature or request
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@marlonmarcello @andrewrubin