Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added check for Show/Hide setting #47

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

SnowB1
Copy link
Contributor

@SnowB1 SnowB1 commented Dec 22, 2023

  • Updated the shortcode provider to check for the page setting

Summary

Added a check for the page setting in the shortcode provider

Testing Steps

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "master"

- Updated the shortcode provider to check for the page setting
@SnowB1 SnowB1 added the patch label Dec 22, 2023
@SnowB1 SnowB1 requested a review from tiller1010 December 22, 2023 11:45
Copy link
Member

@tiller1010 tiller1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SnowB1 SnowB1 merged commit f46e285 into main Dec 22, 2023
3 checks passed
@github-actions github-actions bot deleted the hotfix/2.1.5/shortcode-check-showhide branch December 22, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants