Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change skus listing route #623

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: change skus listing route #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion marketplace/services/vtex/private/products/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ def list_all_active_products(self, domain):
print(f"Fetched SKUs for domain {domain} and stored in cache.")
return skus

def list_all_skus_ids(self, domain):
return self.client.list_all_products_sku_ids(domain)

def list_all_products(
self,
domain: str,
Expand Down Expand Up @@ -110,7 +113,7 @@ def list_all_products(
else:
sellers_ids = list(active_sellers)

skus_ids = self.list_all_active_products(domain)
skus_ids = self.list_all_skus_ids(domain)
rules = self._load_rules(config.get("rules", []))
store_domain = config.get("store_domain")

Expand Down
10 changes: 7 additions & 3 deletions marketplace/services/vtex/private/products/tests/test_private_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,16 @@ def test_list_all_active_products(self, mock_cache_set, mock_cache_get):
@patch("django.core.cache.cache.get")
def test_list_all_products(self, mock_cache_get):
self.service.data_processor.process_product_data = Mock(return_value=[])
self.mock_client.list_all_active_products = Mock(return_value=["sku1", "sku2"])
self.mock_client.list_all_products_sku_ids = Mock(return_value=["sku1", "sku2"])
self.mock_client.list_active_sellers = Mock(return_value=["seller1", "seller2"])
mock_cache_get.return_value = ["sku1", "sku2"]

products = self.service.list_all_products("valid.domain.com", self.mock_catalog)

mock_cache_get.assert_called_once_with("active_products_valid.domain.com")
self.mock_client.list_all_products_sku_ids.assert_called_once_with(
"valid.domain.com"
)
self.mock_client.list_active_sellers.assert_called_once_with("valid.domain.com")
self.assertIsInstance(products, list)

def test_get_product_details(self):
Expand Down Expand Up @@ -151,7 +155,7 @@ def test_load_rules(self):
def test_list_all_products_with_invalid_sellers(self):
sellers = ["seller1", "invalid_seller"]
self.service.list_active_sellers = Mock(return_value=["seller1", "seller2"])
self.service.list_all_active_products = Mock(return_value=["sku1", "sku2"])
self.service.list_all_skus_ids = Mock(return_value=["sku1", "sku2"])
self.service.data_processor.process_product_data = Mock(return_value=[])

with patch("builtins.print") as mock_print:
Expand Down