Skip to content

Commit

Permalink
fix: change skus listing route
Browse files Browse the repository at this point in the history
  • Loading branch information
elitonzky committed Feb 20, 2025
1 parent cf89830 commit ffacd1d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
5 changes: 4 additions & 1 deletion marketplace/services/vtex/private/products/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ def list_all_active_products(self, domain):
print(f"Fetched SKUs for domain {domain} and stored in cache.")
return skus

def list_all_skus_ids(self, domain):
return self.client.list_all_products_sku_ids(domain)

def list_all_products(
self,
domain: str,
Expand Down Expand Up @@ -110,7 +113,7 @@ def list_all_products(
else:
sellers_ids = list(active_sellers)

skus_ids = self.list_all_active_products(domain)
skus_ids = self.list_all_skus_ids(domain)
rules = self._load_rules(config.get("rules", []))
store_domain = config.get("store_domain")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,16 @@ def test_list_all_active_products(self, mock_cache_set, mock_cache_get):
@patch("django.core.cache.cache.get")
def test_list_all_products(self, mock_cache_get):
self.service.data_processor.process_product_data = Mock(return_value=[])
self.mock_client.list_all_active_products = Mock(return_value=["sku1", "sku2"])
self.mock_client.list_all_products_sku_ids = Mock(return_value=["sku1", "sku2"])
self.mock_client.list_active_sellers = Mock(return_value=["seller1", "seller2"])
mock_cache_get.return_value = ["sku1", "sku2"]

products = self.service.list_all_products("valid.domain.com", self.mock_catalog)

mock_cache_get.assert_called_once_with("active_products_valid.domain.com")
self.mock_client.list_all_products_sku_ids.assert_called_once_with(
"valid.domain.com"
)
self.mock_client.list_active_sellers.assert_called_once_with("valid.domain.com")
self.assertIsInstance(products, list)

def test_get_product_details(self):
Expand Down Expand Up @@ -151,7 +155,7 @@ def test_load_rules(self):
def test_list_all_products_with_invalid_sellers(self):
sellers = ["seller1", "invalid_seller"]
self.service.list_active_sellers = Mock(return_value=["seller1", "seller2"])
self.service.list_all_active_products = Mock(return_value=["sku1", "sku2"])
self.service.list_all_skus_ids = Mock(return_value=["sku1", "sku2"])
self.service.data_processor.process_product_data = Mock(return_value=[])

with patch("builtins.print") as mock_print:
Expand Down

0 comments on commit ffacd1d

Please sign in to comment.