feat: improve codes #183
Merged
feat: improve codes #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MrWindlike
commented
Oct 16, 2024
MrWindlike
commented
- 原 Table 组件重命名为 InternalBaseTable，这个组件只是内部使用，外部可传入自定义的表格组件进行使用。然后封装一个更上层的 Table 组件方便外部编写 field 使用
- EditField 允许在提交时返回 false 来阻止表单提交，用于校验场景
- PVC 编辑分配量表单添加校验
- 添加新的状态
MrWindlike
commented
Oct 16, 2024
| }; | ||
| const resourceStateMap: Record<string, Record<string, StatusCapsuleColor | 'loading'>> = {}; |
There was a problem hiding this comment.
如果资源有单独的状态定义可写在这里，现在暂时没有用上，先保留为空对象
MrWindlike
commented
Oct 16, 2024
| import { TableProps as BaseTableProps, RequiredColumnProps, Table as BaseTable, Pagination, Loading } from '@cloudtower/eagle'; | ||
| import { css, cx } from '@linaria/core'; | ||
| import React, { useMemo, useRef } from 'react'; | ||
| import { cx } from '@linaria/core'; |
There was a problem hiding this comment.
由于文件重命名的关系，这里的 diff 不准确，可以只看新增的内容即可
MrWindlike
commented
Oct 16, 2024
| @@ -0,0 +1,149 @@ | |||
| import { TableProps as BaseTableProps, RequiredColumnProps, Table as BaseTable, Pagination, Loading } from '@cloudtower/eagle'; | |||
There was a problem hiding this comment.
由 Table 重命名为 InternalBaseTable，内容无变化
tanbowensg
reviewed
Oct 16, 2024
|
|
||
| return ( | ||
| <Button | ||
| prefixIcon={<PlusAddCreateNew16BoldOntintIcon />} | ||
| type="primary" | ||
| onClick={openForm} | ||
| > | ||
| {t('dovetail.create_resource', { resource: resource?.meta?.kind })} | ||
| {t('dovetail.create_resource', { resource: /^[a-zA-Z]/.test(label) ? ` ${label}` : label })} |
There was a problem hiding this comment.
判断是否为英文开头，是则加上空格
tanbowensg
reviewed
Oct 16, 2024
| @@ -12,8 +12,8 @@ | |||
| "fetch_schema_fail": "获取 schema 失败。", | |||
| "obtain_data_error": "Having trouble getting data.", | |||
| "retry": "Retry", | |||
| "create_resource": "Create {{resource}}", | |||
There was a problem hiding this comment.
对，现在改成用 JS 动态判断加上空格
1. add the new Table component 2. allow EditField to stop submit when the form is invalid 3. add validators for pvc storage form 4. add new states for StateTag
MrWindlike
force-pushed
the
feat/resources
branch
from
bd3856f to
59ce74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.