You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
I must first thank you for your work as this has helped us a lot.
I found an issue during transaction ID generation that you might want to fix.
I have a statement that ended up with the same transaction id for two distinct transactions.
The current implementation seems to do a hash of the transaction but the issue stem from the fact that this generation is done before adding the description on the transaction object.
Hello,
I must first thank you for your work as this has helped us a lot.
I found an issue during transaction ID generation that you might want to fix.
I have a statement that ended up with the same transaction id for two distinct transactions.
The current implementation seems to do a hash of the transaction but the issue stem from the fact that this generation is done before adding the description on the transaction object.
This is where the hash is computed but at that time, the description hasn't been updated/parsed yet
https://github.com/webschik/mt940-js/blob/master/src/tags/transaction-info.ts#L128
I ended up with the following transactions.
As you can see the only thing that differ is the description but as it is not used during id computation, I ended up with the same ID
The text was updated successfully, but these errors were encountered: