Skip to content

Feature -> Develop | Added Local Storage option #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

we-mohd-i001
Copy link

@we-mohd-i001 we-mohd-i001 commented May 23, 2024

Task #9596 - Flutter > VaahFlutter > Research > Add Local Storage (Hive)

Task #9615 - Flutter > VaahFlutter > Research > Add Local Storage (FLutter Secure Storage)

Task #9751 - Flutter > VaahFlutter > Local Storage > Improvement

Time invested: 96:45 | Billable: 96:45 | Non-Billable: 00:00

Problem Statement

  1. The VaahFlutter doesn't have an option for local storage.

Describe The Fix/ Solution You Implemented

  1. I have added a local storage solution with two packages i.e., Hive and Flutter Secure Storage.
  2. An abstract class Storage has been added such that it can be implemented by both Hive and Flutter secure storage.

Proof of your testing (Demo link or video links or image links)

Dependencies
Updated:

Added:

  • hive: ^2.2.3
  • path_provider: ^2.1.3
  • flutter_secure_storage: ^9.1.1

Merge Request Checklist

  • I have performed a self-review of my code
  • My code does follow industry standards
  • My code doesn't produce warnings/ errors for dart analyzer
  • New and existing tests pass locally with my changes (No tests are there as of now)
  • The code modified as part of this PR has been covered with tests
  • My code is properly formatted
  • I've followed the proper naming conventions
  • I have rebased the feature on the latest develop
  • I have run flutter run after the rebase
  • I have added new dependencies/ updated old dependencies
  • I have read all the comments & notes in wireframe and verified that I did take care of that
  • verify that the UI must match with design & wireframe if available
  • I have updated the version/ build (x.x.x+xxx)
  • I've verified that the latest commit of develop exists in your feature branch after rebase.
  • My fix achieves 100% of what is required
  • Can enhance the solution in the future because better implementation could be made

@we-prajapati-c001 we-prajapati-c001 self-requested a review May 27, 2024 05:02
@we-mohd-i001 we-mohd-i001 force-pushed the feature/add-local-storage branch 4 times, most recently from 979592f to f80f573 Compare June 13, 2024 13:32
@we-mohd-i001 we-mohd-i001 force-pushed the feature/add-local-storage branch from 3e72079 to 2299443 Compare June 14, 2024 13:33
@we-mohd-i001 we-mohd-i001 force-pushed the feature/add-local-storage branch 2 times, most recently from 5683b8a to dce850a Compare June 27, 2024 12:51
@we-mohd-i001 we-mohd-i001 force-pushed the feature/add-local-storage branch 6 times, most recently from b958cd0 to b05e28b Compare July 19, 2024 13:22
@we-mohd-i001 we-mohd-i001 force-pushed the feature/add-local-storage branch 3 times, most recently from 5813238 to 196c193 Compare July 23, 2024 13:21
@we-prajapati-c001
Copy link
Collaborator

Handing this over to @we-kislay-k001 from @we-mohd-i001

@we-kislay-k001 we-kislay-k001 force-pushed the feature/add-local-storage branch from 62997d1 to 0a7f5a4 Compare January 31, 2025 10:48
@we-prajapati-c001 we-prajapati-c001 dismissed stale reviews from we-khushal-y001 and themself January 31, 2025 14:16

Outdated Code

@we-prajapati-c001 we-prajapati-c001 force-pushed the feature/add-local-storage branch 2 times, most recently from f9d2ecd to fc9ce7c Compare January 31, 2025 14:32
@we-prajapati-c001 we-prajapati-c001 force-pushed the feature/add-local-storage branch from fc9ce7c to 1d51fe0 Compare February 18, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants