[scoped-custom-element-registry] Fix TypeError in WebKit #611
+610
−546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebKit's prototype native scoped elements registry doesn't like getting a `registry` object in attachShadow(). The previous state did attempt to remove `registry`, but the key was getting renamed by Closure.
|
Important The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it. |
sorvell
reviewed
Feb 26, 2025
packages/scoped-custom-element-registry/src/scoped-custom-element-registry.ts
Show resolved
Hide resolved
sorvell
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit's prototype native scoped elements registry doesn't like getting a
registrykey inattachShadow().The previous state did attempt to remove
registry, but the key was getting renamed by Closure.Fixes #609
This PR also updates Playwright and enables WebKit Playwright tests in the scoped-custom-element-registry package. Other repo tests are failing on CI, so CI isn't any help here. The scoped-custom-element-registry package tests are passing locally for me.
edit: I should have noted that WebKit had 23 test failures before the fix. All passing after the fix.