Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema.json #117

Closed
wants to merge 1 commit into from
Closed

Conversation

jogibear9988
Copy link
Contributor

Add external Stylesheets

Add external Stylesheets
@jogibear9988
Copy link
Contributor Author

fix for #116

@justinfagnani
Copy link
Collaborator

Thanks for the PR, and sorry it's taken me so long to review it.

Some notes on contributing:

  1. Let's come to an agreement on the issue before making a PR
  2. The PR title should be more descriptive than just "Update schema.json". Most PRs are going to update the schema in some way.
  3. You need to make edits to schema.d.ts, then generate schema.json by running `npm run build'

On this feature, I'm not sure of the utility or who we actually specify this, so I'd like to close this until we have a clearer picture on #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants