added group, version, separator to constants

Author: ca7alindev

internal/client/magento.go

@@ -9,6 +9,10 @@ import (
 	"github.com/go-resty/resty/v2"
 )
 
+const (
+	separator = "/"
+)
+
 // Desired represents the desired state of a resource.
 type Desired struct {
 	ID   string `json:"id"`
@@ -20,7 +24,7 @@ func GetResourceByID(c *Client, id string) (*Desired, error) {
 	if id == "" {
 		return nil, errors.New("resource with ID" + id + " in " + c.Path + " not found")
 	}
-	resp, _ := c.Create().R().Get(c.Path + "/" + id)
+	resp, _ := c.Create().R().Get(c.Path + separator + id)
 	if resp.StatusCode() != http.StatusOK {
 		return nil, errors.New("resource in " + c.Path + " not found")
 	}
@@ -59,7 +63,7 @@ func UpdateResourceByID(c *Client, id string, observed map[string]interface{}) e
 	requestBody := map[string]interface{}{
 		strings.ToLower(observed["kind"].(string)): observed["spec"].(map[string]interface{})["forProvider"],
 	}
-	_, err := c.Create().R().SetBody(requestBody).Put(c.Path + "/" + id)
+	_, err := c.Create().R().SetBody(requestBody).Put(c.Path + separator + id)
 	if err != nil {
 		return err
 	}
@@ -69,7 +73,7 @@ func UpdateResourceByID(c *Client, id string, observed map[string]interface{}) e
 
 // DeleteResourceByID deletes a resource by its ID at specified api endpoint.
 func DeleteResourceByID(c *Client, id string) error {
-	_, err := c.Create().R().Delete(c.Path + "/" + id)
+	_, err := c.Create().R().Delete(c.Path + separator + id)
 	return err
 }
 

internal/controller/magento.go

@@ -51,6 +51,8 @@ const (
 	api          = "/rest"
 	id           = "external-id"
 	separator    = "/"
+	group        = "magento.web7.md"
+	version      = "v1alpha1"
 )
 
 // MagentoService is a service that can connect to Magento API.
@@ -93,7 +95,7 @@ var (
 
 // isValidGVK returns true if the GroupVersionKind is a valid Magento API resource.
 func isValidGVK(gvk schema.GroupVersionKind) bool {
-	return gvk.Group == "magento.web7.md" && gvk.Version == "v1alpha1" &&
+	return gvk.Group == group && gvk.Version == version &&
 		!strings.Contains(gvk.Kind, "Options") && !strings.Contains(gvk.Kind, "List") &&
 		!strings.Contains(gvk.Kind, "Event") && !strings.Contains(gvk.Kind, "Config")
 }